modify __set_item__ to treat non-int value as tuple #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryneedell
changed the title
|
Hey @jerryneedell! Thanks for this fix! It looks like you are adding in the mpy file accidentally. Please remove that and push to the same branch of yours. The pull request will be automatically updated when you do that. No need to open a second. |
|
@tannewt sorry about the .mpy - I have removed it and pushed - do I need to do anything else? |
|
Nope! Thats it! Thanks @jerryneedell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the noepixel driver consistent with the dotstart driver in handling input values. as written this drive will ignore input values of type other than int or tuple. The change allows values of type list to be accepted and fixes the known problem with some of the example scripts.